bdelacretaz commented on a change in pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6#discussion_r582158075
##########
File path:
src/main/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java
##########
@@ -72,8 +76,21 @@
policy = ReferencePolicy.DYNAMIC
)
)
+@Designate(ocd=SlingScriptEngineManager.Config.class)
public class SlingScriptEngineManager extends ScriptEngineManager implements
BundleListener {
+ @ObjectClassDefinition(name ="Apache Sling Script Engine Manager",
+ description="Configures options for the Script Engine Manager")
+ public @interface Config {
+
+ @AttributeDefinition(name = "Includes", description = "Regular
expressions to match script engines to include (matched against short names).")
Review comment:
Sure, "is included" works! And same for the ignores of course. This is
just a suggestion anyway but it felt clearer to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
