[
https://issues.apache.org/jira/browse/SLING-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290856#comment-17290856
]
Angela Schreiber commented on SLING-10164:
------------------------------------------
[~cziegeler], i wasn't planning to add more metrics (at least not in a first
step). but it might need a careful review by someone familiar with sling-auth
and sling-metrics. a few points:
- would it be better/sensible to capture everything in {{handleSecurity}}
(instead of just covering the likely more expensive parts that call
{{doHandleSecurity}}?
- tests: i was looking for an osgi-test covering the {{SlingAuthenticator}} to
make sure the metrics are actually called as intended.... but as far as i could
see there are only basic unit tests.... (see also SLING-10163)
- dependency to sling-commons-metrics: i would appreciate if someone could
verify that this is the correct way of adding metrics and that the dependency
is introduced properly not causing any regressions
- performance: i would definitely want to avoid introducing any kind of
performance issues just for the sake of having a bunch of metrics. but i didn't
perform any kind of test and didn't a particular performance-test section for
the authenticator.... maybe just missed it).
> Add basic metrics to SlingAuthenticator
> ---------------------------------------
>
> Key: SLING-10164
> URL: https://issues.apache.org/jira/browse/SLING-10164
> Project: Sling
> Issue Type: New Feature
> Components: Authentication
> Reporter: Angela Schreiber
> Priority: Major
> Attachments: SLING-10164.patch
>
>
> IMHO it would be good to capture some basic metrics in {{SlingAuthenticator}}
> that allow to monitor overall login performance and success/failures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
