[
https://issues.apache.org/jira/browse/SLING-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296014#comment-17296014
]
Angela Schreiber commented on SLING-10162:
------------------------------------------
[~cziegeler]..... hmmmm... i got
{code}
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationHandler.java:64:
warning: empty <p> tag
[ERROR] * <p>
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationHandler.java:141:
error: attribute not supported in HTML5: summary
[ERROR] * <table summary="">
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/AuthUtil.java:400:
warning: no @param for loginForm
[ERROR] public static boolean checkReferer(HttpServletRequest request,
String loginForm) {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/impl/AbstractAuthenticationHandlerHolder.java:115:
warning: no @return
[ERROR] protected abstract AuthenticationFeedbackHandler
getFeedbackHandler();
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/engine/auth/AuthenticationHandler.java:49:
error: attribute not supported in HTML5: summary
[ERROR] * <table summary="">
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AbstractAuthenticationFormServlet.java:311:
warning: no @return
[ERROR] protected String getDefaultFormPath() {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AbstractAuthenticationFormServlet.java:325:
warning: no @return
[ERROR] protected String getCustomFormPath() {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/DefaultAuthenticationFeedbackHandler.java:72:
warning: no @param for request
[ERROR] public static boolean handleRedirect(final HttpServletRequest
request,
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/DefaultAuthenticationFeedbackHandler.java:72:
warning: no @param for response
[ERROR] public static boolean handleRedirect(final HttpServletRequest
request,
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AbstractAuthenticationHandler.java:183:
warning: no @param for request
[ERROR] public static boolean isRedirectValid(final HttpServletRequest
request, final String target) {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AbstractAuthenticationHandler.java:183:
warning: no @param for target
[ERROR] public static boolean isRedirectValid(final HttpServletRequest
request, final String target) {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AbstractAuthenticationHandler.java:183:
warning: no @return
[ERROR] public static boolean isRedirectValid(final HttpServletRequest
request, final String target) {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationInfo.java:142:
warning: no @return
[ERROR] public final String getAuthType() {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationInfo.java:158:
warning: no @return
[ERROR] public final String getUser() {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationInfo.java:174:
warning: no @return
[ERROR] public final char[] getPassword() {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationInfo.java:182:
error: attribute not supported in HTML5: summary
[ERROR] * <table summary="">
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationInfoPostProcessor.java:50:
warning: no description for @param
[ERROR] * @param info
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationInfoPostProcessor.java:51:
warning: no description for @param
[ERROR] * @param request
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/auth/core/spi/AuthenticationInfoPostProcessor.java:52:
warning: no description for @param
[ERROR] * @param response
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/engine/auth/AuthenticationInfo.java:98:
warning: no @return
[ERROR] public String getAuthType() {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/engine/auth/AuthenticationInfo.java:106:
warning: no @return
[ERROR] public Credentials getCredentials() {
[ERROR] ^
[ERROR]
/Users/angela/Dev/sling/sling-org-apache-sling-auth-core/src/main/java/org/apache/sling/engine/auth/AuthenticationInfo.java:115:
warning: no @return
[ERROR] public String getWorkspaceName() {
[ERROR] ^
{code}
but the reason why i even tried it was the fact that there are broken javadoc
links in {{SlingAuthenticator}}.
> Fix javadoc in sling.auth.core
> ------------------------------
>
> Key: SLING-10162
> URL: https://issues.apache.org/jira/browse/SLING-10162
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Reporter: Angela Schreiber
> Priority: Major
>
> executing mvn javadoc:javadoc for sling.auth.core fails with java 11 and logs
> warnings with java 8.
> i also noticed a bunch of broken javadoc links in
> {{org.apache.sling.auth.core.impl.SlingAuthenticator}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
