kwin commented on a change in pull request #62:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/62#discussion_r593418511
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java
##########
@@ -248,14 +245,6 @@ public void addDependency(@NotNull Dependency dependency) {
IOUtils.copy(input, output);
}
- // copy the required resources
Review comment:
TBH: These lines are totally unclear to me, package metadata is supposed
to be located below `META-INF` never below `jcr_root`. I just removed them,
because the original metadata are already contained in the transformed package
and only `filter.xml` and `properties.xml` is replaced, which seems fine to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
