stbischof commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r593817229
##########
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##########
@@ -66,9 +67,11 @@
public static final String OPT_REPOSITORY_URLS = "u";
- public static final String OPT_CONFIG_CLASH = "CC";
+ public static final String OPT_CONFIG_CLASH = "C";
- public static final String OPT_ARTICACT_CLASH = "C";
Review comment:
but that means that you are not able to use the options properly.
Example: you want to set the ConfigClash `a=1` then you use `-CCa=1`.
The Parser will decide on `-C` that you mean the ARTICACT_CLASH and uses
`Ca=1` as KeyVal.
```
java.lang.IllegalArgumentException: Unable to parse mvn coordinates/url: Ca
at org.apache.sling.feature.ArtifactId.parse(ArtifactId.java:103)
at
org.apache.sling.feature.launcher.impl.Main.lambda$parseArgs$2(Main.java:257)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at
org.apache.sling.feature.launcher.impl.Main.lambda$parseArgs$3(Main.java:257)
at java.base/java.util.Optional.ifPresent(Optional.java:176)
at org.apache.sling.feature.launcher.impl.Main.parseArgs(Main.java:256)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
