karlpauls commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#discussion_r594155190
##########
File path: pom.xml
##########
@@ -41,34 +42,44 @@
<build>
<plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-dependency-plugin</artifactId>
- <executions>
- <execution>
- <id>unpack-dependencies</id>
- <phase>prepare-package</phase>
- <goals>
- <goal>unpack-dependencies</goal>
- </goals>
- <configuration>
- <excludes>META-INF/**</excludes>
-
<outputDirectory>${project.build.directory}/classes</outputDirectory>
- <overWriteReleases>false</overWriteReleases>
- <overWriteSnapshots>true</overWriteSnapshots>
-
<includeArtifactIds>osgi.core,commons-text,commons-lang3,org.apache.sling.feature,org.osgi.util.function,org.apache.felix.cm.json,org.apache.sling.commons.johnzon,org.apache.felix.converter,commons-cli,slf4j-api,slf4j-simple</includeArtifactIds>
+ <plugin>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-maven-plugin</artifactId>
+ <configuration>
+ <bnd><![CDATA[
+ Main-Class: org.apache.sling.feature.launcher.impl.Main
+ -exportcontents:\
+ org.apache.sling.feature.launcher.spi.*
+ -conditionalpackage:\
+ javax.json*,\
+ org.apache.commons.cli.*,\
+ org.apache.commons.lang3.*,\
+ org.apache.commons.text.*,\
+ org.apache.felix.cm.json.*,\
+ org.apache.felix.converter.*,\
+ org.apache.johnzon.core.*,\
+ org.apache.johnzon.core.util.*,\
+ org.apache.sling.feature.*,\
+ org.osgi.*,\
Review comment:
I think you only removed it from the -conditionalpackage. The manifest
still looks like this for me:
```
Import-Package: java.io,java.lang,java.lang.annotation,java.lang.invoke,
java.lang.reflect,java.math,java.net,java.nio,java.nio.charset,java.nio
.file,java.nio.file.attribute,java.security,java.text,java.util,java.ut
il.concurrent,java.util.concurrent.atomic,java.util.function,java.util.
jar,java.util.logging,java.util.regex,java.util.stream,java.util.zip,ja
vax.script,javax.xml.xpath,org.osgi.framework;version="[1.9,2)",org.osg
i.framework.launch;version="[1.2,2)",org.osgi.framework.startlevel;vers
ion="[1.0,2)",org.osgi.resource;version="[1.0,2)",org.osgi.util.tracker
;version="[1.5,2)",org.xml.sax
```
I don't think we need the import for
org.osgi.framework,org.osgi.framework.launch,org.osgi.framework.startlevel,,org.osgi.resource,org.osgi.util.tracker
Additionally, I wonder if we need the import for javax.script - that seems
odd. Not sure about javax.xml.xpath and org.xml.sax. That might not be needed
either....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
