enapps-enorman commented on a change in pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/13#discussion_r599002608
##########
File path:
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java
##########
@@ -16,31 +16,37 @@
*/
package org.apache.sling.jcr.repoinit.impl;
-import java.util.List;
+import java.util.ArrayList;
import java.util.Calendar;
+import java.util.List;
-import javax.jcr.Session;
import javax.jcr.Node;
import javax.jcr.PathNotFoundException;
-import javax.jcr.Value;
import javax.jcr.PropertyType;
import javax.jcr.RepositoryException;
+import javax.jcr.Session;
+import javax.jcr.Value;
+import org.apache.jackrabbit.api.security.user.Authorizable;
+import org.apache.jackrabbit.util.Text;
import org.apache.jackrabbit.value.BooleanValue;
import org.apache.jackrabbit.value.DateValue;
import org.apache.jackrabbit.value.DoubleValue;
import org.apache.jackrabbit.value.LongValue;
import org.apache.jackrabbit.value.StringValue;
-
import org.apache.sling.repoinit.parser.operations.PropertyLine;
import org.apache.sling.repoinit.parser.operations.SetProperties;
+import org.jetbrains.annotations.NotNull;
/**
* OperationVisitor which processes only operations related to setting node
* properties. Having several such specialized visitors makes it easy to
control
* the execution order.
*/
class NodePropertiesVisitor extends DoNothingVisitor {
+ private static final String PATH_AUTHORIZABLE = ":authorizable:";
Review comment:
I'll add a comment blurb before those constants to provide some details.
Regarding new tests, those would be in a different project, so I added
subtask [SLING-10252](https://issues.apache.org/jira/browse/SLING-10252) for
tracking that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
