anchela commented on pull request #67: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/67#issuecomment-805582227
@karlpauls , i resolved most of the TODOs and FIXMEs (except for those depending on repo-init-parser-fixes). as discussed yesterday i also incorporated the ability to 'record' additional arbitrary system-user-ids with the default-acl-manager that are not contained in the content package(s)..... i didn't yet extend the launcher though that would allow to leverage this additional option when starting the converter (as we discussed). the main open tasks/questions IMHO are now: - how to make sure that the operation-visitor covers everything the parser allows for (even for the more exotic parts no implementation exists)? -> my preferred option would be SLING-10236 i.e. keeping the generation of the repo init statements together with the parser. this would also address the known problems marked with FIXME. - if SLING-10236 is not an option: how do we address the known issues? how will the converter be maintained as repo-init evolves (and who will take care of that)? - the DefaultAclManager still 'manually' creates repo-init statements..... IMHO it would be ideal if we could get rid of those and replace them by repo-init Operation objects that then exported as repo-init statements as we do for the repo-init conversion. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
