Hi Cris, On Wed, Mar 24, 2021 at 11:06 PM Cris Rockwell <[email protected]> wrote: > Options: > 1. Refactor TokenStore [1] and add unit tests....
I'm not an expert on TokenStore but I was curious how hard testing it would be...and I ended up committing some tests [1] Feel free to merge or replace with your own test code, I just thought I'd save my experiments. The TokenStore test coverage is pretty good now, but I didn't dig into getActiveToken() which probably deserves more testing. > ...I would then update my derivative work for the Saml TokenStore... I agree that it makes sense to use the same code for both if you need a store there. Sometimes it's useful to just embed a class from another module, as a way to reuse small things without needing to turn them into libraries. HTH but it's not much, just me being curious and willing to improve test coverage as usual. -Bertrand [1] https://github.com/apache/sling-org-apache-sling-auth-form/blob/master/src/test/java/org/apache/sling/auth/form/impl/TokenStoreTest.java
