[
https://issues.apache.org/jira/browse/SLING-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-10267:
-----------------------------------
Description:
I debugged in the {{SlingAuthenticator}} recently and noticed that all
{{sling.auth.requirements}} configured for the {{SlingAuthenticator}} are
internally registered twice. This is because they get registered once
explicitly from the configuration and then again via the {{ServiceListener}}
that evaluates the {{sling.auth.requirements}} from any service.
I think this causes no harm except for a very minor performance overhead when
scanning throug all authentication requirements.
Note: the effect can also be observed in the web console, where entries
configured on the {{SlingAuthenticator}} are listed twice.
cc [~cziegeler] as you have been working on auth core recently. Looking at the
latest code, I believe this issue survived your refactoring.
was:
I debugged in the {{SlingAuthenticator}} recently and noticed that all
{{sling.authentication.requirements}} configured for the {{SlingAuthenticator}}
are internally registered twice. This is because they get registered once
explicitly from the configuration and then again via the {{ServiceListener}}
that evaluates the {{sling.authentication.requirements}} from any service.
I think this causes no harm except for a very minor performance overhead when
scanning throug all authentication requirements.
Note: the effect can also be observed in the web console, where entries
configured on the {{SlingAuthenticator}} are listed twice.
cc [~cziegeler] as you have been working on auth core recently. Looking at the
latest code, I believe this issue survived your refactoring.
> Authentication requirements from SlingAuthenticator config registered twice
> ---------------------------------------------------------------------------
>
> Key: SLING-10267
> URL: https://issues.apache.org/jira/browse/SLING-10267
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.5.0
> Reporter: Julian Sedding
> Priority: Minor
>
> I debugged in the {{SlingAuthenticator}} recently and noticed that all
> {{sling.auth.requirements}} configured for the {{SlingAuthenticator}} are
> internally registered twice. This is because they get registered once
> explicitly from the configuration and then again via the {{ServiceListener}}
> that evaluates the {{sling.auth.requirements}} from any service.
> I think this causes no harm except for a very minor performance overhead when
> scanning throug all authentication requirements.
> Note: the effect can also be observed in the web console, where entries
> configured on the {{SlingAuthenticator}} are listed twice.
> cc [~cziegeler] as you have been working on auth core recently. Looking at
> the latest code, I believe this issue survived your refactoring.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
