enapps-enorman edited a comment on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#issuecomment-812632248
@stbischof Thanks for looking into this. I think this is closer to matching the behavior from the 1.1.16 release, but it is still a bit different. Specifically, for the use case where "-v" arg is supplied with no arg value the log level should be "debug" instead of "info". The 1.1.16 release had these behaviors: - with no "-v" argument the log level was "info" - with "-v" argument (no arg value supplied) the log level was "debug" - with "-v" argument (arg value supplied) -- this was not supported and the arg value was ignored and the log level was always "debug" The current behavior with this PR is: - with no "-v" argument the log level is "info" -- correct and backward compatible - with "-v" argument (no arg value supplied) the log level is "info" -- incorrect and not backward compatible should be "debug" - with "-v" argument (arg value supplied) the log level is set to the arg value -- correct and new behavior with no backward equivalent So it basically needs two different "default" values so the log level becomes "info" when "-v" is not there and "debug" when "-v" is there (and no arg value was supplied). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
