kwin commented on a change in pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-core/pull/8#discussion_r607767364



##########
File path: 
src/main/java/org/apache/sling/auth/core/impl/AuthenticationRequirementsManager.java
##########
@@ -390,7 +390,7 @@ private void addService(final ResourceMapper mapper, final 
ServiceReference<?> r
     private void modifiedService(final ResourceMapper mapper, final 
ServiceReference<?> ref) {
         final String[] authReqPaths = 
Converters.standardConverter().convert(ref.getProperty(AuthConstants.AUTH_REQUIREMENTS)).to(String[].class);
         final Long id = (Long)ref.getProperty(Constants.SERVICE_ID);
-        if ( authReqPaths.length > 0 ) {
+        if ( authReqPaths != null && authReqPaths.length > 0 ) {

Review comment:
       That is probably then a bug in the underlying Felix Converter you are 
using. You should update to a more recent version: 
https://github.com/apache/felix-dev/commits/master/converter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to