[
https://issues.apache.org/jira/browse/SLING-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315494#comment-17315494
]
Karl Pauls commented on SLING-10274:
------------------------------------
[~cziegeler], I suppose the question is: what is the expectation wrt. repoinit?
We have the converter now use the repoinit parser objects to construct the
repoinit - hence, we have to deal with the way they do their conversion to
repoinit. Right now, that is using the platform line separator - hence,
updating to the parser objects will break the tests again on windows.
I guess the correct way would be to rewrite the tests as well to use the parser
objects....
> Consistently use platform independent line separator
> ----------------------------------------------------
>
> Key: SLING-10274
> URL: https://issues.apache.org/jira/browse/SLING-10274
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
> Reporter: Angela Schreiber
> Priority: Minor
>
> [~kpauls], as discussed offline SLING-10268 will introduce platform
> independent line separators for all generated repo-init statements. However,
> the converter code base seems to have a difficult history with line
> separators:
> - originally they seemed to be mostly platform-independent but tests were not
> - test got fixed with
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/6c2ef9929c3e12acf4b7b104871816a6e3e15f4e
> - then with SLING-10121 platform independent separators got replaced by \n
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/86b412dffc2c9c5654745f5ab1946d758b11004a
> IMHO going with platform independent separators would be better.... so, i
> would suggest to revert tests back and fix any potential remaining usages of
> \n in the code base. wdyt?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
