[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315770#comment-17315770
]
Stefan Bischof edited comment on SLING-10229 at 4/7/21, 3:35 PM:
-----------------------------------------------------------------
[~rombert] i added an
[PR|https://github.com/rombert/sling-org-apache-sling-feature-launcher/pull/1]
to your repo.
this let be build and push an image (with latest and version tag) via dockerhub
automades build using a build-hook and an empty dockerfile.
DockerHub overview with buildlogs and images
https://hub.docker.com/repository/docker/stbischof/sling-org-apache-sling-feature-launcher
was (Author: [email protected]):
[~rombert] i added an
[PR|https://github.com/rombert/sling-org-apache-sling-feature-launcher/pull/1]
to your repo.
this let be build and push an container via dockerhub automades build using a
build-hook and an empty dockerfile.
DockerHub overview with buildlogs and images
https://hub.docker.com/repository/docker/stbischof/sling-org-apache-sling-feature-launcher
> [LauncherContainer]Set up automated builds for this Docker image
> -----------------------------------------------------------------
>
> Key: SLING-10229
> URL: https://issues.apache.org/jira/browse/SLING-10229
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: Stefan Bischof
> Priority: Minor
>
> This is an leftover from an other PR:
> [~rombert]: in
> [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18]
> "I think it would be good to set up automated builds for this Docker image
> eventually ( not in scope of this PR ). Looking at
> https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds,
> it looks like the Docker build is basically invoking a top-level Dockerfile.
> Maybe we should move the 'launch' Dockerfile where the plug-in expects it and
> leave the top-level Dockerfile as an entry point for Dockerhub automated
> builds?"
> ---
> I am not sure what you mean with `launch`Dockerfile. And that would mean that
> we have 2 files?
> The Docker Hub automated build uses a file, that could be specified in
> Docker-hub. They use the Tag/Branch as the version tag of the image. But we
> are holding the version just inside maven. So I am not sure that this
> automated build from the Dockerhub-side is the best way. And we are back at
> the point where we have to find a way to copy the launcher-${version].jar
> without changing the Dockerfile in every version just because of the
> different names.
> I would really like to have this official container automated in the docker
> hub.
> But I do not know how to solve this with your CI-Tooling / Access rights on
> DockerHub.
> Having an jenkins that builds every commit with the -P container option and
> pushes the images would be the easiest way.
> regards
> Stefan
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
