enapps-enorman commented on a change in pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r613455149
##########
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##########
@@ -174,8 +179,9 @@ protected static void parseArgs(final LauncherConfig
config, final String[] args
final Option fwkProperties = Option.builder(OPT_FRAMEWORK_PROPERTIES)
.longOpt("framework-properties")
.desc("Set framework properties")
+ .hasArg()
.optionalArg(true)
Review comment:
Injecting the "-D " like that might work, but I was initially thinking
to just document the syntax and expect the user to supply the "-D " segments
manually with something like this:
```
# NOTE: expected syntax: -D name1=value1 -D name2=value2
FRAMEWORK_PROPERTIES="-D a=1 -D b=2 -D c=3"
```
I'm not sure the additional complexity is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
