Hi Robert

FYI, when I ran `groovy collect-sling-repos.groovy > default.xml` as mentioned 
in sling-aggregator, I saw more changed to default.xml than just this new repo. 
Three entries added and one removed see below for the diff. Those seemed like 
valid changes, so I committed them [0] 

diff --git a/default.xml b/default.xml
index 8f3cfae..7067865 100644
--- a/default.xml
+++ b/default.xml

+  <project path='org-apache-sling-auth-saml2' 
name='sling-org-apache-sling-auth-saml2.git' groups='auth' />
+  <project path='org-apache-sling-jcr-maintenance' 
name='sling-org-apache-sling-jcr-maintenance.git' groups='jcr' />
-    <project path='org-apache-sling-scripting-spi' 
name='sling-org-apache-sling-scripting-spi.git' groups='scripting' />
+  <project path='org-apache-sling-scripting-spi' 
name='sling-org-apache-sling-scripting-spi.git' groups='scripting' />


I could not get the badge script to work using `./add-badges.sh ../ 
${NEW_REPO}` 
Ran it a few ways, but seems the docs suggest it should be  `./add-badges.sh 
../ org-apache-sling-auth-saml2` 

I did add badges to the project README.md [2] but did not change the aggregator 
modules.md file [3]

Lastly, I opened ticket SLING-10315 so hopefully the project can have sonar 
cloud analysis.

Let me know if you think I missed something.

Thanks
Cris

[0] 
https://github.com/apache/sling-aggregator/commit/18eebc1d100cfc5a806600c157e26635186b6c07
 
[1] https://github.com/apache/sling-${NEW_REPO}.git
[2] 
https://github.com/apache/sling-org-apache-sling-auth-saml2/blob/master/README.md
[3] https://github.com/apache/sling-aggregator/blob/master/docs/modules.md
[4] https://issues.apache.org/jira/browse/SLING-10315




> On Apr 16, 2021, at 4:53 AM, Robert Munteanu <[email protected]> wrote:
> 
> On Tue, 2021-04-13 at 10:32 -0400, Cris Rockwell wrote:
>> Thank you, Robert. 
>> I look forward to the new repo, and discussing the project’s use 
>> of the Shibboleth repository and it’s dependencies.
> 
> Done - see https://github.com/apache/sling-org-apache-sling-auth-saml2
> . You should be able to proceed with the rest of the steps as
> documented at [1], let me know if something doesn't work as intended.
> 
> Thanks,
> Robert
> 
> [1]:
> https://cwiki.apache.org/confluence/display/SLING/Using+Git+with+Sling#UsingGitwithSling-Creatingnewrepositories
> 

Reply via email to