[ 
https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330414#comment-17330414
 ] 

Bertrand Delacretaz commented on SLING-10118:
---------------------------------------------

bq. in SLING-10085 the GraphQLSchema couldn't be cached due to wired 
resource....

I don't understand, does that mean the SLING-10085 caching is not working? Not 
sure what you mean by "wired resource", can you clarify?

bq. The key for the map is to use the current thread...

I don't understand this either, maybe clarifying the "wired resource" term will 
also clarify this?

> Fully cache GraphQLSchema
> -------------------------
>
>                 Key: SLING-10118
>                 URL: https://issues.apache.org/jira/browse/SLING-10118
>             Project: Sling
>          Issue Type: Bug
>          Components: GraphQL
>    Affects Versions: GraphQL Core 0.0.10
>            Reporter: Thierry Ygé
>            Priority: Major
>
> Currently in SLING-10085 the GraphQLSchema couldn't be cached due to wired 
> resource.
> Thus it still need half the time to spend on building the schema, while 
> generally the resource is only used to be passed later to the fetcher. As 
> that resource then change, I suggested to wrap it via a proxy Resource 
> implementation that would be passed instead of the real resource.
> That proxy will then use a map  to lookup for the current resource used at 
> execute/validate time. The key for the map is to use the current thread.
> I will submit a PR with the solution I suggest to use.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to