kwin commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r621906842
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/handlers/DefaultEntryHandlersManager.java
##########
@@ -30,10 +31,10 @@
private final List<EntryHandler> entryHandlers = new LinkedList<>();
public DefaultEntryHandlersManager() {
- this(Collections.emptyMap(), false);
+ this(Collections.emptyMap(), false, SlingInitialContentPolicy.KEEP);
}
- public DefaultEntryHandlersManager(@NotNull Map<String, String> configs,
boolean enforceConfigurationsAndBundlesBelowProperFolder) {
+ public DefaultEntryHandlersManager(@NotNull Map<String, String> configs,
boolean enforceConfigurationsAndBundlesBelowProperFolder,
SlingInitialContentPolicy slingInitialContentPolicy) {
ServiceLoader<EntryHandler> entryHandlersLoader =
ServiceLoader.load(EntryHandler.class);
for (EntryHandler entryHandler : entryHandlersLoader) {
if (configs.containsKey(entryHandler.getClass().getName())) {
Review comment:
Done in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74/commits/88bb353f6e2bc6ceec24c8e60d49e5bb0c1e93f0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
