kwin commented on pull request #9:
URL: 
https://github.com/apache/sling-org-apache-sling-xss/pull/9#issuecomment-844120467


   > It seems however that the bundle doesn't correctly embed what we had 
before:
   > 
   > ```
   > ERROR : bundle org.apache.sling.xss:2.2.13.SNAPSHOT 
(138)[org.apache.sling.xss.impl.XSSFilterImpl(514)] : The activate method has 
thrown an exception
   > java.lang.NoClassDefFoundError: org/xml/sax/SAXException
   >    at org.apache.sling.xss.impl.PolicyHandler.<init>(PolicyHandler.java:52)
   >    at 
org.apache.sling.xss.impl.XSSFilterImpl.updatePolicy(XSSFilterImpl.java:311)
   >    at 
org.apache.sling.xss.impl.XSSFilterImpl.activate(XSSFilterImpl.java:263)
   > ```
   
   It is just that `org.xml.sax` is not mentioned as Private-Package. IMHO we 
should really try to clean it up, as now we do it twice. I will try to come up 
with a new PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to