enapps-enorman commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-auth-form/pull/1#issuecomment-844569430
> * I _think_ we could use `JcrResourceConstants.AUTHENTICATION_INFO_CREDENTIALS` without taking an extra dependency since the constant values should be included. If not, we should at least extract it to a constant as we're using the value twice now Yes, I have changed it to use that constant and the binary looks ok to me. > * would it be possible to add a test for this? I've added some simple paxexam integration tests to verify that the http client gets the cookies sent at the appropriate times. Let me know if you have any concerns with the tests or had something else in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
