bdelacretaz commented on a change in pull request #25:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/25#discussion_r640393058
##########
File path: pom.xml
##########
@@ -374,5 +379,17 @@
<bnd.index.generation.skip>false</bnd.index.generation.skip>
</properties>
</profile>
+ <profile>
+ <id>enableDocker-linux</id>
+ <properties>
+ <docker.skip>false</docker.skip>
+ </properties>
+ <activation>
+ <!-- Activate on Linux systems. Assume presence of docker.pid
file indicates Docker is available -->
+ <file>
+ <exists>/var/run/docker.pid</exists>
Review comment:
As mentioned in SLING-10402 I think this is fragile, and requires
special configurations for every platform which is not convenient. I think
detecting Docker reliably would require trying to connect to it and detecting
failure. I haven't found a Maven plugin that does that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
