anchela commented on a change in pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/12#discussion_r640782683



##########
File path: src/test/resources/testcases/test-10.txt
##########
@@ -4,6 +4,7 @@
 set ACL on /libs,/apps, /, /content/example.com/some-other_path
     remove * for user1,user2
     allow jcr:read for user1,user2
+    allow noNamespace for user4

Review comment:
       for the sake of clarity i would probably change 'noNamespace' to 
'privilege_without_namespace' to make it unambigous that this is actually a 
privilege name (and not a namespace thing).

##########
File path: src/test/resources/testcases/test-99.txt
##########
@@ -13,6 +13,7 @@ create service user user1, u-ser_2
 set ACL on /libs,/apps
     remove * for user1,u-ser_2
     allow jcr:read for user1,u-ser_2
+    allow noNamespace for user4

Review comment:
       same here....




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to