[
https://issues.apache.org/jira/browse/SLING-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353381#comment-17353381
]
Dan Klco commented on SLING-10430:
----------------------------------
Changes look good to me thanks [~olli]!
IMO stripping off just the newline is the best approach because this fix is
addressing a specific issue with POSIX text utilities that will opaquely add a
newline to the end of files, not the user error of a user accidentally adding
whitespace characters.
> Add fix for POSIX newline in password files
> -------------------------------------------
>
> Key: SLING-10430
> URL: https://issues.apache.org/jira/browse/SLING-10430
> Project: Sling
> Issue Type: New Feature
> Components: Commons
> Reporter: Oliver Lietz
> Assignee: Oliver Lietz
> Priority: Major
> Fix For: Commons Crypto 1.1.0
>
>
> POSIX recommends (_shall_) to terminate lines in regular text files with
> newline character ({{\n}}).
> Tools on UNIX/POSIX systems therefore add a newline character by default to
> terminate lines and also expect a newline character:
> {noformat}
> beat:resources olli$ wc -l password.ascii85
> 0 password.ascii85
> beat:resources olli$ cat password.ascii85
> +AQ?aDes!'DBMkrCi:FE6q\sOn=Pbmn=PK8n=PK?beat:resources olli$ wc -l
> password.ascii85_newline
> 1 password.ascii85_newline
> beat:resources olli$ cat password.ascii85_newline
> +AQ?aDes!'DBMkrCi:FE6q\sOn=Pbmn=PK8n=PK?
> beat:resources olli$
> {noformat}
> * {{wc}} reports zero lines for {{password.ascii85}}
> * output for {{password.ascii85}} on shell from {{cat}} looks flawed
> The extra newline character leads to an error (SLING-10415) with misleading
> message:
> {noformat}
> org.jasypt.exceptions.EncryptionInitializationException:
> java.security.spec.InvalidKeySpecException: Password is not ASCII
> at
> org.jasypt.encryption.pbe.StandardPBEByteEncryptor.initialize(StandardPBEByteEncryptor.java:773)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
