Hi Stefan,

I think we should take the time to make the bundle buildable with Java 11
and above. I’ll try to create an issue for it tomorrow.

Thanks,
Radu

On Wed, 2 Jun 2021 at 19:55, Stefan Seifert
<[email protected]> wrote:

> oh, your're right - build runs fine with java 8.
> maybe we should add a maven enforcer rule to make sure the build is
> failing in java > 8 with an appropriate message.
>
> here is my +1 on this release.
>
> stefan
>
> >-----Original Message-----
> >From: Stefan Seifert <[email protected]>
> >Sent: Wednesday, June 2, 2021 7:01 PM
> >To: [email protected]
> >Subject: RE: [VOTE] Release Apache Sling Scripting Java 2.1.6
> >
> >i'm not able to run the unit tests locally (tested on windows and in a
> unix
> >VM) - i always get the same error as on Jenkins:
> >https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-
> >sling-scripting-java/job/master/52/console
> >
> >[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-
> >plugin:1.8:run (set-bundle-required-execution-environment) on project
> >org.apache.sling.scripting.java: An Ant BuildException has occured: Unable
> >to create javax script engine for javascript
> >[ERROR] around Ant part ...<script language="javascript">var System =
> >java.lang.System;... @ 4:33 in D:\Develop\OpenSource\sling-git\sling-org-
> >apache-sling-scripting-java\target\antrun\build-main.xml
> >
> >
> >stefan
> >
> >
> >>-----Original Message-----
> >>From: Radu Cotescu <[email protected]>
> >>Sent: Wednesday, June 2, 2021 6:16 PM
> >>To: Sling Developers List <[email protected]>
> >>Subject: [VOTE] Release Apache Sling Scripting Java 2.1.6
> >>
> >>Hi,
> >>
> >>We solved 2 issues in this release:
> >>https://issues.apache.org/jira/browse/SLING/fixforversion/12338861
> >>
> >>Staging repository:
> >>https://repository.apache.org/content/repositories/orgapachesling-2464/
> >>
> >>You can use this UNIX script to download the release and verify the
> >>signatures:
> >>https://gitbox.apache.org/repos/asf?p=sling-tooling-
> >>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >>
> >>Usage:
> >>sh check_staged_release.sh 2464 /tmp/sling-staging
> >>
> >>Please vote to approve this release:
> >>
> >>  [ ] +1 Approve the release
> >>  [ ]  0 Don't care
> >>  [ ] -1 Don't release, because ...
> >>
> >>This majority vote is open for at least 72 hours.
> >>
> >>Regards,
> >>Radu Cotescu
>

Reply via email to