[ 
https://issues.apache.org/jira/browse/SLING-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359408#comment-17359408
 ] 

Angela Schreiber commented on SLING-10468:
------------------------------------------

[~kpauls], if i am not mistaken the culprit is the 
{{AbstractUserEntryHandler}}, which catches all users, all groups and all 
intermediate paths and doesn't write those parts back that are not transformed 
to repo-init (namely groups, regular users and their intermediate paths). 
probably a regression from our goal to make sure we can properly identify 
service-user-permissions that point to user and group homes (in contrast to 
those pointing to other service users, which is supported).
probably {{AbstractUserEntryHandler}} needs something similar to 
{{AbstractPolicyEntryHandler}} i.e. the parser returned a boolean instead of 
void and subsequently writing the current entry back to the package if it has 
not been moved to repo-init. 

something like
{code}
            boolean rejectedUser;
            AbstractUserParser parser = createParser(converter, originalPath, 
intermediatePath);
            try (InputStream input = archive.openInputStream(entry)) {
                rejectedUser = parser.parse(input);
            }

            if (rejectedUser) {
                // TODO write entry back to the package
            }
{code}

> Converted content package is missing some .content.xml
> ------------------------------------------------------
>
>                 Key: SLING-10468
>                 URL: https://issues.apache.org/jira/browse/SLING-10468
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>            Reporter: Angela Schreiber
>            Priority: Major
>         Attachments: 
> demo-cp-no-su-ace-at-group-folder-0.0.0-cp2fm-converted.zip, 
> demo-cp-no-su-ace-at-group-folder.zip
>
>
> [~kpauls], when trying to install the converted content package as attached 
> to  SLING-10467 the import failed with {{ConstraintViolationException}} 
> because the intermediate nodes for the demo-cp group and the regular user 
> does no longer come with a _.content.xml_ defining it's node type and 
> jackrabbit fvault resorting to it's _nt:folder_ default, which is not allowed 
> by {{rep:AuthorizableFolder}}.
> In order to exclude the possibility that this is caused by the {{rep:policy}} 
> node attached to the user/group folder nodes containing an ACE for one of the 
> service users in the package, I created a slightly modified package that 
> doesn't come with a AC policy at _/home/groups/demo-cp_ (but still has one 
> with _/home/users/demo-cp_).
> Running the converter however returned the same output:
> There is no longer exists a _.content.xml_ file with neither the intermediate 
> authorizable folder mentioned above. Not sure where that gets lost, but it 
> looks like a bug to me (and will essentially prevent the converted content 
> package from being installed). 
> Am I missing something???



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to