Hi Stefan, That's a good catch. I took a look at why that test fails on windows and it looks like it is because the TokenStore#saveTokens method calls "tmpTokenFile.renameTo(tokenFile)". On windows the File.renameTo call fails if the destination file already exists. From what I can tell this has been failing all along but there were no tests for the TokenStore until a couple months ago.
I've opened SLING-10472 <https://issues.apache.org/jira/browse/SLING-10472> for tracking the problem. I'm going to cancel the release and include the fix for that problem and then call for a new vote. Regards, Eric On Tue, Jun 8, 2021 at 7:58 AM Stefan Seifert <[email protected]> wrote: > +1 > > > please note that the unit test do not run on my (windows) machine (they > are running fine on linux, so it'S not a release blocker) > > [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 3.948 s <<< FAILURE! - in org.apache.sling.auth.form.impl.TokenStoreTest > [ERROR] org.apache.sling.auth.form.impl.TokenStoreTest.loadTokenFileTest > Time elapsed: 0.02 s <<< FAILURE! > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:87) > at org.junit.Assert.assertTrue(Assert.java:42) > at org.junit.Assert.assertTrue(Assert.java:53) > at > org.apache.sling.auth.form.impl.TokenStoreTest.loadTokenFileTest(TokenStoreTest.java:92) > ... >
