[ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366589#comment-17366589
 ] 

Denis Moret commented on SLING-10503:
-------------------------------------

I've removed the schema definition variable that wasn't used anymore anyway and 
added the selectors instead. 

I think keeping the ERROR level is better to avoid missing any potential error 
that would be logged in INFO messages. 

> DefaultQueyExecutor should not log the full Schema Definition on error
> ----------------------------------------------------------------------
>
>                 Key: SLING-10503
>                 URL: https://issues.apache.org/jira/browse/SLING-10503
>             Project: Sling
>          Issue Type: Improvement
>          Components: GraphQL
>    Affects Versions: GraphQL Core 0.0.10
>            Reporter: Denis Moret
>            Priority: Major
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to