[
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10503:
----------------------------------------
Description:
If an exception is caught during a query execution, the full schema definition
is logged. If the schema is large or if the error is repeating, it might induce
a large quantity of logs.
I would suggest to log the schema definition on DEBUG log level only.
[https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]
_Update: as discussed below we have removed the schema from the logs, as it can
be quite big. And added the selectors to log messages, which together with the
Resource path allow the schema to be recreated if needed_
was:
If an exception is caught during a query execution, the full schema definition
is logged. If the schema is large or if the error is repeating, it might induce
a large quantity of logs.
I would suggest to log the schema definition on DEBUG log level only.
[https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]
> DefaultQueryExecutor should not log the full Schema Definition on error
> -----------------------------------------------------------------------
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
> Affects Versions: GraphQL Core 0.0.10
> Reporter: Denis Moret
> Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> If an exception is caught during a query execution, the full schema
> definition is logged. If the schema is large or if the error is repeating, it
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]
> _Update: as discussed below we have removed the schema from the logs, as it
> can be quite big. And added the selectors to log messages, which together
> with the Resource path allow the schema to be recreated if needed_
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
