[ 
https://issues.apache.org/jira/browse/SLING-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368085#comment-17368085
 ] 

Christian Schneider commented on SLING-10527:
---------------------------------------------

It makes a lot of sense to log when the package was imported. It is as well 
important though to also log when we start to import a package.
>From that information I was able to see which package was stuck for a customer 
>and which offset in the topic the package was at.

What do you think about also logging the "Importing.. " message at info level?

> Log imported instead of importing package
> -----------------------------------------
>
>                 Key: SLING-10527
>                 URL: https://issues.apache.org/jira/browse/SLING-10527
>             Project: Sling
>          Issue Type: Bug
>          Components: Content Distribution
>            Reporter: Timothee Maret
>            Assignee: Timothee Maret
>            Priority: Major
>             Fix For: Content Distribution Journal Core 0.1.18
>
>
> Currently the package import is logged at INFO level before processing the 
> package
> {code}
> log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
> {code}
> This makes it difficult to figure out if there was an error with the import 
> because one has to seek further logs to see if the package import failed or 
> (worst) no log if the package was imported successfully. We should ensure 
> that a single log statement is logged upon import, either the import 
> succeeded or failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to