Hmm, somethings not quite right with my patch, the integration tests fail.
Investigating.
Ian

On 25 Feb 2011, at 11:05, Carsten Ziegeler wrote:

> Hi,
> 
> at a first look, the changes look fine to me; however it is too long ago
> that I touched the code... :)
> 
> Regards
> Carsten
> 
> Ian Boston  wrote
>> Jirad at https://issues.apache.org/jira/browse/SLING-1995
>> Since I've had no comments, I assume this is Ok and wont break others work.
>> Ian
>> 
>> On 24 Feb 2011, at 13:28, Ian Boston wrote:
>> 
>>> Hi,
>>> 
>>> The ContentLoader only updates content if the bundle is updated. If the 
>>> bundle was installed while the container was not running, it doesnt get the 
>>> "updated" state and so is ignored.
>>> 
>>> [1] looks at the lastModified state of the bundle and compares it to the 
>>> lastModfied time of the content loader registration node, so that if the 
>>> bundle is newer, the content gets loaded, even if the bundle was installed 
>>> when the container was not running.
>>> 
>>> WDYT?
>>> Should I commit ?
>>> 
>>> (doing review then commit since I haven't every patched this area)
>>> Ian
>>> 
>>> 1 http://codereview.appspot.com/4220045
>> 
>> 
> 
> 
> -- 
> Carsten Ziegeler
> [email protected]

Reply via email to