Thank you Konrad. I agree with your points and due to the nature of the last 3 I hereby cancel the release.
One question though, according to https://sling.apache.org/documentation/development/release-management.html#wait-for-the-results I should not reuse the version number. Is that the case for the first version/1.0.0 as well or would it be safe to assume no one copied the binaries around yet? > When restarting a vote version numbers must not be reused, since binaries > might have already been copied around. Thanks, Dirk On Tue, 29 Jun 2021 at 15:04, Konrad Windszus <[email protected]> wrote: > > Hi Dirk, > I have some general remarks (mostly minor ones but one should be IMHO fixed > before release) > - Can you update https://sling.apache.org/repolist.html as the new Github > repo doesn't appear there yet. > - Please also use the most recent parent version (43 at the time of writing). > A lot of plugin configuration and the profile named "autoInstallBundle" > doesn't need to be repeated per module as it is inherited from parent. > - Please also make sure to include all badges used in other modules in the > readme via > https://github.com/apache/sling-aggregator/blob/master/generate-badges.groovy. > - Please don't mix Consumer and Provider interfaces in the same package > (https://github.com/apache/sling-org-apache-sling-sitemap/tree/master/src/main/java/org/apache/sling/sitemap/generator > and > https://github.com/apache/sling-org-apache-sling-sitemap/tree/master/src/main/java/org/apache/sling/sitemap/builder/extensions) > as that enforces updates to break more consumers than necessary. This should > be done prior to the 1.0 release. > - SitemapGenerator.GenerationContext should rather be named > SitemapGenerator.Context or SitemapGenerator.GeneratorContext. > - Make SitemapUtil final to ease semantic versioning > > > Apart from that looks really nice and looking forward to the release. > Thanks, > Konrad > > > > > On 28. Jun 2021, at 13:20, Dirk Rudolph <[email protected]> wrote: > > > > Hi, > > > > We solved 1 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12350352 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2484 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2484 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > - Dirk >
