On Tue, 2021-06-29 at 18:48 -0400, Cris Rockwell wrote: > Hi Robert > > > Why are there version ranges used in the pom? > I was using Maven bracket notation for version ranges that I had > actually tested. But I see it’s not needed, and removed the bracket > range on the versions. Now it builds without downloading any SNAPSHOTS. > > > > checker-qual-2.11.1.jar > > error_prone_annotations-2.3.4.jar > > failureaccess-1.0.1.jar > > These are dependencies of Google Guava, which is also an embedded > dependency. If I didn't embed Guava, the deps above wouldn’t be needed. > Sling comes with Guava v15. But OpenSAML libraries currently require > 30.1.1-jre. Having a recent version of Guava installed as a bundle > could help a lot. But having both versions as bundles doesn’t seem to > work. I am getting the error below...
As Julian mentioned, embedding Guava is the only safe solution right now. And thank you for looking into the additional dependencies and making sure they can be used as OSGi bundles, this will make deployments simpler. > > Import-Package: com.codahale.metrics; version="[4.1, 5)", > com.google.common.base; version="[30.1, 31)", > com.google.common.collect; version="[30.1, 31)", > com.google.common.escape; version="[30.1, 31)", com.google.common.io; > version="[30.1, 31)", com.google.common.net; version="[30.1, 31)", > > > metrics-core-4.1.9.jar > > Upgrading metrics-core past v3 causes a lot of problems with many > Sling bundles. I counted ~40 bundles that went from Active to > Installed state. But when installed with parallel versions (v3 and > v4) everything seems fine. > Is the metrics bundle something you're consuming or required by a dependency? Ideally we would be working with whatever is supported by the current Sling Starter / commons.metrics bundle. Thanks, Robert
