[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384900#comment-17384900
]
Bertrand Delacretaz commented on SLING-10229:
---------------------------------------------
IIUC the goal of this is to build the Docker image using the
[https://docs.docker.com/docker-hub/builds/advanced/] mechanism, and I suppose
this happens on the hub.docker.com infrastructure.
If that's correct, do we know if there are limitations in terms of resource
usage? There might be limitations on how many build requests hub.docker.com
accepts from a single GitHub organization (which https://github.com/apache/ is)
in a given time frame.
RTFM links to existing documentation are welcome!
> [LauncherContainer]Set up automated builds for this Docker image
> -----------------------------------------------------------------
>
> Key: SLING-10229
> URL: https://issues.apache.org/jira/browse/SLING-10229
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: Stefan Bischof
> Priority: Minor
>
> This is an leftover from an other PR:
> [~rombert]: in
> [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18]
> "I think it would be good to set up automated builds for this Docker image
> eventually ( not in scope of this PR ). Looking at
> https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds,
> it looks like the Docker build is basically invoking a top-level Dockerfile.
> Maybe we should move the 'launch' Dockerfile where the plug-in expects it and
> leave the top-level Dockerfile as an entry point for Dockerhub automated
> builds?"
> ---
> I am not sure what you mean with `launch`Dockerfile. And that would mean that
> we have 2 files?
> The Docker Hub automated build uses a file, that could be specified in
> Docker-hub. They use the Tag/Branch as the version tag of the image. But we
> are holding the version just inside maven. So I am not sure that this
> automated build from the Dockerhub-side is the best way. And we are back at
> the point where we have to find a way to copy the launcher-${version].jar
> without changing the Dockerfile in every version just because of the
> different names.
> I would really like to have this official container automated in the docker
> hub.
> But I do not know how to solve this with your CI-Tooling / Access rights on
> DockerHub.
> Having an jenkins that builds every commit with the -P container option and
> pushes the images would be the easiest way.
> regards
> Stefan
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
