anchela edited a comment on pull request #98:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98#issuecomment-891836226
@karlpauls , i would appreciate if you had time to review the proposed fixes.
in particular the calculation of the repository-paths in
VaultPackageAssembler line 360ff. as outline in SLING-10699 the vault-internal
paths end with .xml and include .content.xml that has not equivalent in the the
repository. i had a look at a few existing content packages that filter out
users and rep:policy nodes and all either just had the real repository path in
the include/exclude or made it a reg exp like the following example (slighly
modified after an example in Adobe AEM):
```
<filter root="/home" mode="merge">
<include pattern=".*/rep:policy(/.*)?"/>
<include pattern="/home/users(/.*)?"/>
<exclude pattern="/home/users/system"/>
<exclude pattern="/home/users/demo-cp(/.*)?"/>
[...]
</filter>
```
also: do you seen any special cases that deserve additional testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
