[ 
https://issues.apache.org/jira/browse/SLING-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395979#comment-17395979
 ] 

Radu Cotescu commented on SLING-10706:
--------------------------------------

Those cases should actually be handled via 
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/capability/Capabilities.java#L172.

You should think here in terms of Servlet Registrations, rather than scripts. 
For scripts for which the current version of the plugin would not detect a 
resource type (governed by 
https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/76bf25f23fd3ce3d5381db7423a6c01909dcd075/src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderPredicate.java#L70),
 we would still register a Servlet by path. Essentially this would lead to the 
same resolution like with scripts in the repository, since the resolution is 
based on a tree of resources anyways. As such, I don't think that we 
necessarily have a problem in the plugin.

> Order of selectors not kept
> ---------------------------
>
>                 Key: SLING-10706
>                 URL: https://issues.apache.org/jira/browse/SLING-10706
>             Project: Sling
>          Issue Type: Bug
>          Components: Maven Plugins and Archetypes
>    Affects Versions: Scripting Bundle Maven Plugin 0.3.0
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: Scripting Bundle Maven Plugin 0.4.0
>
>
> The selectors used for registration of script/servlets have an order: Only if 
> they appear in the given order the script/servlet matches 
> (https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration).
> The order is potentially lost, though during the generation of the 
> capabilities headers as the code is using Sets internally.
> Also it is totally valid to register a script to "myselector.myselector" 
> which cannot be expressed with Sets either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to