kwin commented on a change in pull request #6:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/6#discussion_r686035967
##########
File path: src/test/resources/spotbugs-exclude.xml
##########
@@ -25,4 +25,11 @@
<!-- false positive - https://github.com/spotbugs/spotbugs/issues/259
-->
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
</Match>
+ <!-- the following two rules are just too strict in the context of this
Maven plugin -->
Review comment:
```
[ERROR] Medium:
org.apache.sling.scriptingbundle.plugin.bnd.BundledScriptsScannerPlugin.getScriptEngineMappings()
may expose internal representation by returning
BundledScriptsScannerPlugin.scriptEngineMappings
[org.apache.sling.scriptingbundle.plugin.bnd.BundledScriptsScannerPlugin] At
BundledScriptsScannerPlugin.java:[line 133] EI_EXPOSE_REP
[ERROR] Medium:
org.apache.sling.scriptingbundle.plugin.bnd.BundledScriptsScannerPlugin.setProperties(Map)
may expose internal representation by storing an externally mutable object
into BundledScriptsScannerPlugin.pluginProperties
[org.apache.sling.scriptingbundle.plugin.bnd.BundledScriptsScannerPlugin] At
BundledScriptsScannerPlugin.java:[line 120] EI_EXPOSE_REP2
[ERROR] Medium: new
org.apache.sling.scriptingbundle.plugin.capability.Capabilities(Set, Set, Set)
may expose internal representation by storing an externally mutable object into
Capabilities.providedResourceTypeCapabilities
[org.apache.sling.scriptingbundle.plugin.capability.Capabilities] At
Capabilities.java:[line 52] EI_EXPOSE_REP2
[ERROR] Medium: new
org.apache.sling.scriptingbundle.plugin.capability.Capabilities(Set, Set, Set)
may expose internal representation by storing an externally mutable object into
Capabilities.providedScriptCapabilities
[org.apache.sling.scriptingbundle.plugin.capability.Capabilities] At
Capabilities.java:[line 53] EI_EXPOSE_REP2
[ERROR] Medium: new
org.apache.sling.scriptingbundle.plugin.capability.Capabilities(Set, Set, Set)
may expose internal representation by storing an externally mutable object into
Capabilities.requiredResourceTypeCapabilities
[org.apache.sling.scriptingbundle.plugin.capability.Capabilities] At
Capabilities.java:[line 54] EI_EXPOSE_REP2
[ERROR] Medium:
org.apache.sling.scriptingbundle.plugin.capability.ProvidedResourceTypeCapability$Builder.withResourceTypes(Set)
may expose internal representation by storing an externally mutable object
into ProvidedResourceTypeCapability$Builder.resourceTypes
[org.apache.sling.scriptingbundle.plugin.capability.ProvidedResourceTypeCapability$Builder]
At ProvidedResourceTypeCapability.java:[line 147] EI_EXPOSE_REP2
[ERROR] Medium:
org.apache.sling.scriptingbundle.plugin.capability.ProvidedResourceTypeCapability$Builder.withSelectors(Set)
may expose internal representation by storing an externally mutable object
into ProvidedResourceTypeCapability$Builder.selectors
[org.apache.sling.scriptingbundle.plugin.capability.ProvidedResourceTypeCapability$Builder]
At ProvidedResourceTypeCapability.java:[line 190] EI_EXPOSE_REP2
[ERROR] Medium: new
org.apache.sling.scriptingbundle.plugin.capability.ProvidedScriptCapability$Builder(Map)
may expose internal representation by storing an externally mutable object
into ProvidedScriptCapability$Builder.scriptEngineMappings
[org.apache.sling.scriptingbundle.plugin.capability.ProvidedScriptCapability$Builder]
At ProvidedScriptCapability.java:[line 84] EI_EXPOSE_REP2
[ERROR] Medium: new
org.apache.sling.scriptingbundle.plugin.processor.FileProcessor(Logger, Set,
Map) may expose internal representation by storing an externally mutable object
into FileProcessor.scriptEngineMappings
[org.apache.sling.scriptingbundle.plugin.processor.FileProcessor] At
FileProcessor.java:[line 61] EI_EXPOSE_REP2
[ERROR] Medium: new
org.apache.sling.scriptingbundle.plugin.processor.FileProcessor(Logger, Set,
Map) may expose internal representation by storing an externally mutable object
into FileProcessor.searchPaths
[org.apache.sling.scriptingbundle.plugin.processor.FileProcessor] At
FileProcessor.java:[line 60] EI_EXPOSE_REP2
[ERROR] Medium: new
org.apache.sling.scriptingbundle.plugin.processor.PathOnlyScriptAnalyser(Logger,
Path, Map, FileProcessor) may expose internal representation by storing an
externally mutable object into PathOnlyScriptAnalyser.scriptEngineMappings
[org.apache.sling.scriptingbundle.plugin.processor.PathOnlyScriptAnalyser] At
PathOnlyScriptAnalyser.java:[line 48] EI_EXPOSE_REP2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
