anchela commented on a change in pull request #99:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/99#discussion_r699133089
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/shared/AbstractJcrNodeParser.java
##########
@@ -27,15 +27,14 @@
import javax.xml.parsers.SAXParser;
import javax.xml.parsers.SAXParserFactory;
-import org.apache.sling.feature.cpconverter.ConverterException;
import org.jetbrains.annotations.NotNull;
import org.xml.sax.Attributes;
import org.xml.sax.SAXException;
import org.xml.sax.helpers.DefaultHandler;
public abstract class AbstractJcrNodeParser<O> extends DefaultHandler {
- private static final String JCR_ROOT = "jcr:root";
+ public static final String JCR_ROOT = "jcr:root";
Review comment:
hi @kwin , which constant you are referring to? i checked
org.apache.jackrabbit.vault.util.Constants.java and it only contains `String
ROOT_DIR = "jcr_root"`. i would have used a "jcr:root" constant if i had found
one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
