[ 
https://issues.apache.org/jira/browse/SLING-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411089#comment-17411089
 ] 

Bertrand Delacretaz commented on SLING-10645:
---------------------------------------------

What bugs me with use cases 4 and 5 and for the "somewhere in between" option 
of 1 is that they imply that you know the original values. If that's the case, 
you could argue that replacing the whole set has the same effect. Or "almost" 
the same effect but that "almost" is where things possibly become hard to 
understand and troubleshoot.

Anyway, if you want to implement all cases I am not opposed, as long as the 
whole thing is backed by strong tests and clearly documented.

However I would much prefer having just what's actually required, which IIUC is 
a merge mode, maybe with "add before" or "add after" options which are simple 
to understand.

> Update Sling Resource Merger with handling for multi-valued properties
> ----------------------------------------------------------------------
>
>                 Key: SLING-10645
>                 URL: https://issues.apache.org/jira/browse/SLING-10645
>             Project: Sling
>          Issue Type: Improvement
>          Components: ResourceResolver
>    Affects Versions: Resource Merger 1.4.0
>            Reporter: Henry Kuijpers
>            Priority: Major
>
> Sling Resource Merger is able to handle properties, not individual property 
> values.
> When setting up this node structure (with AEM's extraClientlibs property in 
> TouchUI dialogs):
> + /libs/wcm/basicpage/cq:dialog@extraClientlibs=["a", "b", "c"]
> + /apps/website/components/page@sling:resourceSuperType="wcm/basicpage"
> + /apps/website/components/page/cq:dialog@extraClientlibs=["d", "e"]
> We want to make sure that the extraClientlibs property that is being read in 
> website/components/page/cq:dialog will return ["a", "b", "c", "d", "e"]. 
> Currently, it will just return ["d", "e"], since the extraClientlibs-property 
> is *overwritten*. 
> It would be nice to add additional logic to allow more control over the 
> inheritance of the values that are tied to a parent's 
> extraClientlibs-property.
> Maybe we can come up with some additional properties that can function as 
> instructions to the Resource Merger (next to the ones we already have), so 
> that there can be more fine-grained control over the inheritance/removal of 
> property values in multi-valued scenarios.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to