[
https://issues.apache.org/jira/browse/SLING-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333656#comment-16333656
]
Dawid Pura edited comment on SLING-6172 at 9/9/21, 8:41 AM:
------------------------------------------------------------
Why wasn't this merged/developed?
This is the feature that I need for Sling Rewriter Pipelines.
I don't know how to handle this feature along with keeping backward
compatibility. Presumably, there are plenty of configurations out there based
on a fixed path.
was (Author: puradawid):
Any idea why this was not merged/developed?
This is a feature that I also need for Sling Rewriter Pipelines.
I am not sure how to handle this feature along with keeping backward
compatibility. Presumably there are plenty of configurations out there based on
fixed path.
> Sling Rewriter pipelines should support runmode-sensitive configurations via
> OSGi
> ---------------------------------------------------------------------------------
>
> Key: SLING-6172
> URL: https://issues.apache.org/jira/browse/SLING-6172
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
> Affects Versions: Rewriter 1.2.0
> Reporter: Mark Adamcin
> Priority: Major
> Attachments: 0001-Add-initial-OSGi-Config-Support-to-Rewriter.patch
>
>
> I have, a number of times, run into a situation where I need to be able to
> selectively override the AEM default rewriter pipeline based on run mode. I
> read the discussion in a relevant thread
> (http://apache-sling.73963.n3.nabble.com/Configure-rewriter-pipeline-per-runmode-td4022918.html)
> and based on the implementation of ProcessorManagerImpl, it seems that
> extending the observed config resource paths is the most expedient way to
> make this happen without changing the existing behavior with respect to
> config/rewriter paths, and without reimplementing everything for an
> OSGi-config-centric approach.
> The attached patch file introduces a private configuration factory class
> called ProcessorConfigurationMapping that requires only a mapped.path
> property intended to refer to a single rewriter pipeline config node under
> the Resource Resolver search path, but that wouldn't be discovered by the
> current ProcessorManagerImpl implementation.
> The ProcessorManagerImpl has been modified to bind 0..n [static|greedy]
> ProcessorConfigurationMapping instances and to use these mappings to find
> additional config resources during initProcessors() as well as to populate
> the ResourceChangeListener configuration with additional observation paths
> during activation.
> Once activated, the ProcessorManagerImpl treats ResourceChange events on
> these mapped paths just like changes to config/rewriter children.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
