stefan-egli commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/4#discussion_r708148009
##########
File path:
src/test/java/org/apache/sling/discovery/commons/providers/DummyTopologyView.java
##########
@@ -199,7 +200,13 @@ public static DummyTopologyView clone(final
DummyTopologyView view) {
String clusterId = id.getClusterView().getId();
DefaultClusterView cluster = clusters.get(clusterId);
if (cluster==null) {
- cluster = new DefaultClusterView(clusterId);
+ final ClusterView origCluster = id.getClusterView();
+ if (origCluster instanceof LocalClusterView) {
+ final LocalClusterView localOrigCluster =
(LocalClusterView) origCluster;
+ cluster = new LocalClusterView(origCluster.getId(),
localOrigCluster.getLocalClusterSyncTokenId());
Review comment:
It might not be relevant as this dummy test class is not used by the new
code - but I think it needs to copy it as well, to make it consistent. Will do
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
