[
https://issues.apache.org/jira/browse/SLING-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-10813:
--------------------------------
Description:
As discussed [in this
PR|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#discussion_r708292265]
the ViewStateManagerImpl.waitForAsyncEvents returning currently requires a
{{Thread.sleep()}} to ensure anything that was "just triggered" has finished
executing asynchronously.
This should be improved in this waitForAsyncEvent method, by being more precise
about when it returns (ie include any call to `asyncEvent.trigger()` having
terminated)
was:
As discussed [in this
PR|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#discussion_r708292265]
the ViewStateManagerImpl.waitForAsyncEvents returning currently requires a
`Thread.sleep()` to ensure anything that was "just triggered" has finished
executing asynchronously.
This should be improved in this waitForAsyncEvent method, by being more precise
about when it returns (ie include any call to `asyncEvent.trigger()` having
terminated)
> Improve ViewStateManagerImpl.waitForAsyncEvents, also speeds up tests
> ---------------------------------------------------------------------
>
> Key: SLING-10813
> URL: https://issues.apache.org/jira/browse/SLING-10813
> Project: Sling
> Issue Type: Improvement
> Components: Discovery
> Reporter: Stefan Egli
> Priority: Minor
>
> As discussed [in this
> PR|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#discussion_r708292265]
> the ViewStateManagerImpl.waitForAsyncEvents returning currently requires a
> {{Thread.sleep()}} to ensure anything that was "just triggered" has finished
> executing asynchronously.
> This should be improved in this waitForAsyncEvent method, by being more
> precise about when it returns (ie include any call to `asyncEvent.trigger()`
> having terminated)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
