kwin commented on a change in pull request #8:
URL: 
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#discussion_r710831036



##########
File path: 
src/main/java/org/apache/sling/scriptingbundle/plugin/processor/ResourceTypeFolderAnalyser.java
##########
@@ -66,6 +66,8 @@ public Capabilities getCapabilities(@NotNull Path 
resourceTypeDirectory) {
                                 fileProcessor.processExtendsFile(resourceType, 
entry, providedCapabilities, requiredCapabilities);
                             } else if 
(Constants.REQUIRES_FILE.equals(file.toString())) {
                                 fileProcessor.processRequiresFile(entry, 
requiredCapabilities);
+                            } else if 
(org.apache.jackrabbit.vault.util.Constants.DOT_CONTENT_XML.equals(file.toString()))
 {
+                                fileProcessor.processVaultFile(entry, 
resourceType, providedCapabilities, requiredCapabilities);

Review comment:
       The filename -> resource type translation is different for content 
packages as it supports escaping: 
http://jackrabbit.apache.org/filevault/vaultfs.html#Filename_escaping. I guess 
we need to introduce a flag to say if we process bundles or content packages.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to