rombert commented on a change in pull request #21:
URL: https://github.com/apache/sling-parent/pull/21#discussion_r713090837
##########
File path: sling-parent/pom.xml
##########
@@ -151,8 +151,8 @@
</plugin>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>ianal-maven-plugin</artifactId>
+ <groupId>org.apache.geronimo.genesis.plugins</groupId>
Review comment:
Well, we remove one tool which stopped working with a tool that works.
The IANAL plugin has worked for 13 years ( see
https://search.maven.org/search?q=ianal-maven-plugin ). If this unmaintained
one works for 13 more years I'm find :-)
And I do think that we still need to check for legal files, otherwise we
risk shipping out invalid releases. Yes, the risk is small, but why not remove
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]