kwin commented on a change in pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-commons-threads/pull/3#discussion_r713272606
##########
File path: pom.xml
##########
@@ -105,4 +100,9 @@
<version>1.2.6</version>
</dependency>
</dependencies>
+
+ <properties>
+ <sling.java.version>8</sling.java.version>
+ <project.build.outputTimestamp>1</project.build.outputTimestamp>
Review comment:
This does not work due to
https://issues.apache.org/jira/browse/MJAVADOC-684. Instead use a timestamp
like this:
<project.build.outputTimestamp>2021-08-06T09:01:40Z</project.build.outputTimestamp>.
The value does not matter as it is updated automatically during
release:prepare.
##########
File path: pom.xml
##########
@@ -46,20 +45,8 @@
<build>
<plugins>
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
- <configuration>
- <instructions>
- <Bundle-Activator>
- org.apache.sling.commons.threads.impl.Activator
- </Bundle-Activator>
- <Provide-Capability>
-
osgi.service;objectClass=org.apache.sling.commons.threads.ThreadPoolManager,
-
osgi.service;objectClass=org.apache.sling.commons.threads.jmx.ThreadPoolMBean
- </Provide-Capability>
- </instructions>
- </configuration>
+ <groupId>biz.aQute.bnd</groupId>
Review comment:
no need to duplicate this from parent:
https://github.com/apache/sling-parent/blob/79c93908e42e6a3e09421c96ec2b96909741e891/sling-bundle-parent/pom.xml#L167.
The relevant plugins are active by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
