anchela commented on pull request #114:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-941040191
@niekraaijmakers , applied the patch to my local checkout to see what causes
the test failure and spotted 2 more minor things, i would suggest you fix:
- unused import for logger/loggerfactory in JcrNamespaceRegistry
- there is a TODO and a warning related to SLING-10770 on line 308..... can
you drop that as well?:
```
// TODO: SLING-10770, remove this warning when support for CND files is
added - see JcrNamespaceRegistry#registerCnd
logger.warn("Unable to check for CND files for sling inital
content - Not implemented!");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
