kwin commented on a change in pull request #33: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/33#discussion_r735814685
########## File path: src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.sling.feature.analyser.task.impl.contentpackage; + +import java.nio.file.Path; +import java.util.Collection; +import java.util.Collections; + +import org.apache.jackrabbit.vault.fs.api.WorkspaceFilter; +import org.apache.jackrabbit.vault.fs.io.Archive; +import org.apache.jackrabbit.vault.packaging.PackageInfo; +import org.apache.jackrabbit.vault.packaging.PackageProperties; +import org.apache.jackrabbit.vault.validation.spi.ValidationContext; + + +/** + * Implements a validation context based on a given {@link Archive}. + */ +public class ArchiveValidationContextImpl implements ValidationContext { + + private final WorkspaceFilter filter; + private final PackageProperties properties; + private final Path archivePath; + + public ArchiveValidationContextImpl(Archive archive, Path archivePath) { + this.archivePath = archivePath; + properties = archive.getMetaInf().getPackageProperties(); + this.filter = archive.getMetaInf().getFilter(); + if (filter == null) { + throw new IllegalStateException("Archive '" + archivePath + "' does not contain a filter.xml."); + } + } + + @Override + public PackageProperties getProperties() { + return properties; + } + + @Override + public WorkspaceFilter getFilter() { + return filter; + } + + @Override + public ValidationContext getContainerValidationContext() { + return null; + } + + public Path getPackageRootPath() { + return archivePath; + } + + @Override + public Collection<PackageInfo> getDependenciesPackageInfo() { + return Collections.emptyList(); Review comment: You should try to resolve dependencies based on their Maven coordinates from the underlying Maven repository, otherwise some validation may work incorrectly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
