kwin commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737285005
##########
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -65,13 +65,20 @@
@NotNull SlingHttpServletRequestBuilder withSelectors(String ...
selectors);
/**
- * Sets the optional extension of the internal request, which influence
+ * Sets the optional extension of the internal request, which influences
Review comment:
We should use either 3rd person or 2nd person, but not both, currrently
we are mixing both forms in the same class. Oracle recommends using 3rd person:
> Use 3rd person (descriptive) not 2nd person (prescriptive).
> The description is in 3rd person declarative rather than 2nd person
imperative.
>
> Gets the label. (preferred)
>
> Get the label. (avoid)
(https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#styleguide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
