rombert commented on a change in pull request #52:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/52#discussion_r742780945
##########
File path:
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java
##########
@@ -180,8 +184,25 @@ public void close() {
if (factory.shouldLogResourceResolverClosing()) {
closedResolverException = new Exception("Stack Trace");
}
+ clearPropertyMap();
this.factory.unregister(this, this.control);
}
+
+
+ protected void clearPropertyMap() {
+ if (propertyMap != null) {
+ for (Object value : propertyMap.values()) {
+ if (value instanceof Closeable) {
+ try {
+ ((Closeable) value).close();
+ } catch (IOException e) {
Review comment:
I would catch `Exception` here. The reason is that if, for any reason, a
consumer-supplied `close` method throws a `RuntimeException`, the cleaning is
aborted and
- unprocessed closeables will not be closed
- the resource resolver's close process is interrupted, leading to various
leaks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
