enapps-enorman commented on a change in pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743929577
##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+ org.apache.sling.launchpad.testservices.exported,\
+ org.apache.sling.launchpad.testservices.models,\
+ org.apache.sling.launchpad.testservices.events
+
+Private-Package:\
Review comment:
Thanks for the review. This was a direct copy of how the old
maven-bundle-plugin instructions were doing it. I don't have a problem
removing this instruction as it doesn't appear to have any impact on running
the tests.
However, I would note that removing this instruction doesn't prevent this
attribute from showing up in the generated manifest as bnd would just use the
default configuration.
I've seen a few places using the "removeheaders" instruction to remove it
from the output, is this what you were expecting?
-removeheaders:\
Private-Package
##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+ org.apache.sling.launchpad.testservices.exported,\
+ org.apache.sling.launchpad.testservices.models,\
+ org.apache.sling.launchpad.testservices.events
+
+Private-Package:\
Review comment:
Thanks for the review. This was a direct copy of how the old
maven-bundle-plugin instructions were doing it. I don't have a problem
removing this instruction as it doesn't appear to have any impact on running
the tests.
However, I would note that removing this instruction doesn't prevent this
attribute from showing up in the generated manifest as bnd would just use the
default configuration.
I've seen a few places using the "removeheaders" instruction to remove it
from the output, is this what you were expecting?
-removeheaders: Private-Package
##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
Review comment:
Thanks for the review. This was a direct copy of how the old
maven-bundle-plugin instructions were doing it. And yes, you are correct, but
only one of those exported packages contained a package-info.java file so a
little more work is needed here.
I have cleaned this up by adding a package-info.java file to the other two
packages and removed this instruction.
##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+ org.apache.sling.launchpad.testservices.exported,\
+ org.apache.sling.launchpad.testservices.models,\
+ org.apache.sling.launchpad.testservices.events
+
+Private-Package:\
Review comment:
Thanks for the review. This was a direct copy of how the old
maven-bundle-plugin instructions were doing it. I don't have a problem
removing this instruction as it doesn't appear to have any impact on running
the tests.
However, I would note that removing this instruction doesn't prevent this
attribute from showing up in the generated manifest as bnd would just use the
default configuration.
I've seen a few places using the "removeheaders" instruction to remove it
from the output, is this what you were expecting?
-removeheaders:\
Private-Package
##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+ org.apache.sling.launchpad.testservices.exported,\
+ org.apache.sling.launchpad.testservices.models,\
+ org.apache.sling.launchpad.testservices.events
+
+Private-Package:\
Review comment:
Thanks for the review. This was a direct copy of how the old
maven-bundle-plugin instructions were doing it. I don't have a problem
removing this instruction as it doesn't appear to have any impact on running
the tests.
However, I would note that removing this instruction doesn't prevent this
attribute from showing up in the generated manifest as bnd would just use the
default configuration.
I've seen a few places using the "removeheaders" instruction to remove it
from the output, is this what you were expecting?
-removeheaders: Private-Package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
