cziegeler commented on a change in pull request #52:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/52#discussion_r743418480
##########
File path:
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java
##########
@@ -180,8 +184,25 @@ public void close() {
if (factory.shouldLogResourceResolverClosing()) {
closedResolverException = new Exception("Stack Trace");
}
+ clearPropertyMap();
this.factory.unregister(this, this.control);
}
+
+
+ protected void clearPropertyMap() {
+ if (propertyMap != null) {
+ for (Object value : propertyMap.values()) {
+ if (value instanceof Closeable) {
+ try {
+ ((Closeable) value).close();
+ } catch (IOException e) {
Review comment:
I think we either ignore the exceptions (but log them) or we remove the
support for Closeable. I don't want that someone putting something random into
that map blows up close()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
